Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): fix losing for #1144

Merged
merged 4 commits into from
Feb 26, 2021
Merged

fix(form): fix losing for #1144

merged 4 commits into from
Feb 26, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 25, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 25, 2021 •
edited
Loading

Codecov Report

Merging #1144 (94a4c0f) into master (c4cfd44) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1144   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         266      266           
  Lines        8048     8048           
  Branches     1604     1604           
=======================================
  Hits         7751     7751           
  Misses        135      135           
  Partials      162      162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cfd44...b6817b8. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jan 25, 2021 •
edited
Loading

Preview is ready!

@cipchk cipchk changed the title WIP(form): fix losing for fix(form): fix losing for Jan 28, 2021
@cipchk cipchk removed the PR: draft label Feb 26, 2021
@cipchk cipchk merged commit e0ffa64 into master Feb 26, 2021
@cipchk cipchk deleted the issues-sf-missing-id branch February 26, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipchk @ng-alain-bot